feat: improve caching experience

[SgtPooki]

Caching speeds slowed down slightly when adding vercel caching and fixing the fetch Error issues.

We need to investigate if there's anything else we can do to improve speeds here.

There seems to be a caching related performance degradation. Whenever I reload using cmd-r, all of the data is being fetched again, I think it doesn't really use the cache for me

Screen.Recording.2023-06-12.at.09.22.09.mp4

I would expect CMD+R to use the cache. CMD+Shift+R should reload without cache. In the video recording above I'm simply hitting enter on the address bar

It doesn't flash the cached content before refetching, as I described above, it just seems to never use a cache?

Tasks

Beta Give feedback

1. Confirm caching is working at service-worker level (it should return response immediately if it has cache, but re-populate it's cache with a second query)
2. Confirm caching is working at the vercel level (it should have cache-hit or miss value when it has or doesn't have cache)
3. optimize cache-control and stale values

[momack2]

@SgtPooki @BigLep @whizzzkid - can we prioritize this please? This is a major usability issue for starmap and we're planning to use it next week in Iceland

[whizzzkid]

@momack2 looked into it, nothing changed so should not degrade all of a sudden. The slowness is only on first load and not on subsequent. I wonder:

• The tokens used to fetch the content might’ve expired, which makes it take longer because it retries through the expired ones first.
• Github has been slow for me here in Canada, not sure if that contributed to this.
• Vercel might’ve introduced an aggressive sleep cycle on the workers. The cold starts are slower, but subsequently it warms up and work faster.

I validated the caching both on the edge and in the browsers is working as expected. I turned on monitoring on vercel to validate the slow call paths.

link-1.mov

link-2.mov

[momack2]

slow.starmaps.mov

This is what I'm seeing - but maybe the caching works differently than I expect? I expect starmap to load each github issue once, and then cache the content for all future viewers until the content changes so it can provide fast loads. Instead - even though I know I've loaded this page 10+ times since it last changed - I have to wait 30+ seconds for the content to load (even if I close the window and then immediately re-open the page). This makes it very slow and cumbersome to work with.