Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate enum with no keys for large properties files #27

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Generate enum with no keys for large properties files #27

merged 5 commits into from
Jan 16, 2024

Commits on Jan 12, 2024

  1. chore: remove unused code

    @aurambaj
    aurambaj committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a80c607 View commit details
    Browse the repository at this point in the history

  2. test: Add test for enum generation with argument builder

    @aurambaj
    aurambaj committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    b2aa1d4 View commit details
    Browse the repository at this point in the history

  3. feat: Generate enum with no keys for large properties files 

    Use EnumType#NO_KEYS in @L10nProperties to generate an enum with no keys.

This can be used to work with large properties files that generate the following compilation
error: "error: code too large" when the enum becomes too large with {@link #KEYS_ONLY} due
the number of keys.

Obviously strong typing does not apply anymore but other enum attribute can be used for
example to create an instance of L10nMessages with {@link L10nMessages#builder(Class)}
    @aurambaj
    aurambaj committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    095e6c2 View commit details
    Browse the repository at this point in the history

  4. feat: Expose the ResourceBundle on L10nMessages 

    This is useful to be able to list the keys when using {@link EnumType#NO_KEYS}
    @aurambaj
    aurambaj committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1e43824 View commit details
    Browse the repository at this point in the history

  5. chore: Use label for relative path to fix bazel build 

    The error was

ERROR: /home/runner/work/l10nmessages/l10nmessages/examples/bazel-local/BUILD:14:12: //:l10nbazel depends on @@l10nmessages_local//:l10nmessages in repository @@l10nmessages_local which failed to fetch. no such package '@@l10nmessages_local//': /home/runner/work/l10nmessages/l10nmessages/examples/bazel-local/external/l10nmessages_local_maven.BUILD.bzl is not a regular file; if you're using a relative or absolute path for `build_file` in your `new_local_repository` rule, please switch to using a label instead
    @aurambaj
    aurambaj committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8f75e27 View commit details
    Browse the repository at this point in the history