Generate enum with no keys for large properties files #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use EnumType#NO_KEYS in @L10nProperties to generate an enum with no keys.
This can be used to work with large properties files that generate the following compilation
error: "error: code too large" when the enum becomes too large with {@link #KEYS_ONLY} due
the number of keys.
Obviously strong typing does not apply anymore but other enum attribute can be used for
example to create an instance of L10nMessages with {@link L10nMessages#builder(Class)}
This is useful to be able to list the keys when using {@link EnumType#NO_KEYS}
aurambaj
force-pushed
the
ja/enum-no-keys
branch
from
e9d8902
to
1e43824
Compare
The error was ERROR: /home/runner/work/l10nmessages/l10nmessages/examples/bazel-local/BUILD:14:12: //:l10nbazel depends on @@l10nmessages_local//:l10nmessages in repository @@l10nmessages_local which failed to fetch. no such package '@@l10nmessages_local//': /home/runner/work/l10nmessages/l10nmessages/examples/bazel-local/external/l10nmessages_local_maven.BUILD.bzl is not a regular file; if you're using a relative or absolute path for `build_file` in your `new_local_repository` rule, please switch to using a label instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it has multiple commits, the main things it changes: