make pd start timeout configurable #5071
Conversation
|
olivia_chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| threshold={{ .PDStartTimeout }} | ||
|
|
||
| elapseTime=0 | ||
| period=1 | ||
| threshold=30 | ||
| while true; do | ||
| sleep ${period} | ||
| elapseTime=$(( elapseTime+period )) | ||
| echo "waiting threshold for pd ${threshold}" |
There was a problem hiding this comment.
update the content of this script (in a ConfigMap) will cause existing PD rolling to restart. How about just replacing threshold=30 with threshold={{ .PDStartTimeout }}?
There was a problem hiding this comment.
updated. can you pls help review again? thx
|
/test pull-e2e-kind-across-kubernetes |
|
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-e2e-kind |
|
@oliviachenairbnb: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@oliviachenairbnb: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@oliviachenairbnb: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
saw ci failing due to unrelated problems. do you have any insights how to pass the ci check? thanks. @csuzhangxc |
"pd_start_script_test.go:558: unexpected (-want, +got): strings.Join({" I think it's related. @oliviachenairbnb |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5071 +/- ##
==========================================
+ Coverage 57.43% 62.16% +4.72%
==========================================
Files 246 250 +4
Lines 28585 31958 +3373
==========================================
+ Hits 16418 19866 +3448
+ Misses 10575 10464 -111
- Partials 1592 1628 +36
|
|
fixed the failing ci. can you pls help review again? thx @csuzhangxc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test pull-e2e-kind |
|
@csuzhangxc: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-e2e-kind |
|
@csuzhangxc: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.5 |
|
@csuzhangxc: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Co-authored-by: olivia_chen <[email protected]>
What problem does this PR solve?
make pd start timeout configurable
What is changed and how does it work?
Update pd start timeout value to make it configurable
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.