Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pd start timeout configurable (#5071) #5095

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5071

What problem does this PR solve?

make pd start timeout configurable

What is changed and how does it work?

Update pd start timeout value to make it configurable

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge June 26, 2023 03:58
@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2023

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

Merging #5095 (50a9b8f) into release-1.5 (3dc9543) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5095      +/-   ##
===============================================
- Coverage        59.04%   59.03%   -0.02%     
===============================================
  Files              228      228              
  Lines            26514    26516       +2     
===============================================
- Hits             15656    15653       -3     
- Misses            9324     9327       +3     
- Partials          1534     1536       +2     
Flag Coverage Δ
unittest 59.03% <100.00%> (-0.02%) ⬇️

@csuzhangxc csuzhangxc merged commit fc03647 into pingcap:release-1.5 Jun 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants