Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add auto sync configuration in creating etcd client (#1240) #1253

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1240

What problem does this PR solve?

Issue Number: close #1236

What is changed and how it works?

Add AutoSyncInterval configuration in creating etcd client.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

fix the problem that drainer/pump can't work when pd's topology changes

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu
Copy link
Contributor

/run-integration-tests

1 similar comment
@lichunzhu
Copy link
Contributor

/run-integration-tests

@purelind
Copy link
Collaborator

/run-integration-tests tikv=release-6.5 pd=release-6.5 tidb=release-6.5 tidb-tools=master

1 similar comment
@lichunzhu
Copy link
Contributor

/run-integration-tests tikv=release-6.5 pd=release-6.5 tidb=release-6.5 tidb-tools=master

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-27 08:56:54.077278309 +0000 UTC m=+697979.478528750: ☑️ agreed by GMHDBJD.
  • 2023-06-27 08:57:32.248095077 +0000 UTC m=+698017.649345518: ☑️ agreed by lichunzhu.

@ti-chi-bot ti-chi-bot bot merged commit 570c346 into pingcap:release-6.5-20230625-v6.5.3 Jun 27, 2023
@lichunzhu
Copy link
Contributor

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member Author

@lichunzhu: new pull request created to branch release-6.1: #1254.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants