Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add auto sync configuration in creating etcd client #1240

Merged
merged 1 commit into from
Jun 5, 2023
Merged

*: add auto sync configuration in creating etcd client #1240

merged 1 commit into from
Jun 5, 2023

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jun 5, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #1236

What is changed and how it works?

Add AutoSyncInterval configuration in creating etcd client.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

fix the problem that drainer/pump can't work when pd's topology changes

@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 5, 2023
niubell
niubell approved these changes Jun 5, 2023
View reviewed changes
Copy link

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-05 07:47:39.456195919 +0000 UTC m=+248045.729168698: ☑️ agreed by niubell.
  • 2023-06-05 07:55:57.144799732 +0000 UTC m=+248543.417772516: ☑️ agreed by lance6716.

@lichunzhu
Copy link
Contributor Author

/merge

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-6.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/recheck

@lichunzhu
Copy link
Contributor Author

/retest

@lichunzhu
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3621449 into pingcap:master Jun 5, 2023
@lichunzhu lichunzhu deleted the fixEtcdAutoSync branch June 5, 2023 09:16
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2023
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.5: #1241.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.5-20230625-v6.5.3

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.5-20230625-v6.5.3: #1253.

In response to this:

/cherry-pick release-6.5-20230625-v6.5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 25, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jun 26, 2023
@ti-chi-bot
*: add auto sync configuration in creating etcd client (#1240) (#1241)
5b001e5 
close #1236
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2023
@ti-chi-bot
*: add auto sync configuration in creating etcd client (#1240) (#1253)
570c346 
close #1236
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
*: add auto sync configuration in creating etcd client (#1240) (#1254)
8668095 
close #1236
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2023
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-7.1: #1261.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 6, 2023
@ti-chi-bot
*: add auto sync configuration in creating etcd client (#1240) (#1261)
d4e1c27 
close #1236
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.4

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2023
Open
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-5.4: #1265.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@niubell niubell niubell approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
approved lgtm release-note size/XS
Projects
None yet
Milestone
No milestone
4 participants
@lichunzhu @ti-chi-bot @lance6716 @niubell