Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-1291: Make wireguard the default option #73

Merged
merged 1 commit into from
Feb 8, 2024
Merged

PIA-1291: Make wireguard the default option #73

merged 1 commit into from
Feb 8, 2024

Conversation

kp-juan-docal
Copy link
Contributor

@kp-juan-docal kp-juan-docal commented Feb 7, 2024 •
edited
Loading

Summary

It introduces the changes to make wireguard the default protocol on new installations and the logic to allow us to migrate to wireguard those on ikev2 with default settings.

Sanity Testers

Tests were performed with the library changes introduced here

  • Clean install. Open app. Confirm wireguard is the selected protocol.
  • Install current production. Without changing any settings. Upgrade to this version. Confirm wireguard is the selected protocol.
  • Install current production. Change any ikev2 setting. Upgrade to this version. Confirm ikev2 is the selected protocol.
  • After the above. Change back to ikev2 defaults. Kill process. Open app. Confirm ikev2 is the selected protocol.
  • After the above. Reset settings. Confirm wireguard is the selected protocol.

@kp-juan-docal kp-juan-docal self-assigned this Feb 7, 2024
@kp-juan-docal kp-juan-docal mentioned this pull request Feb 7, 2024
Merged
5 tasks
@kp-juan-docal kp-juan-docal force-pushed the juan.docal/PIA-1291-make-wireguard-the-default-option branch 2 times, most recently from 4dc0373 to 937b29e Compare February 8, 2024 09:45
@kp-juan-docal kp-juan-docal marked this pull request as ready for review February 8, 2024 09:46
kp-said-rehouni
kp-said-rehouni reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @kp-juan-docal! Just a small comment to address

PIA VPN-tvOS/Bootstraper/BootstraperFactory.swift Outdated Show resolved Hide resolved
@kp-juan-docal kp-juan-docal force-pushed the juan.docal/PIA-1291-make-wireguard-the-default-option branch from 937b29e to d5bbed8 Compare February 8, 2024 09:53
kp-said-rehouni
kp-said-rehouni reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @kp-juan-docal!

kp-said-rehouni
kp-said-rehouni approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @kp-juan-docal!

@kp-juan-docal kp-juan-docal merged commit 06c66c7 into master Feb 8, 2024
1 check failed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-1291-make-wireguard-the-default-option branch February 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-laura-sempere kp-laura-sempere kp-laura-sempere left review comments

@kp-said-rehouni kp-said-rehouni kp-said-rehouni approved these changes

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kp-juan-docal @kp-laura-sempere @kp-said-rehouni