PIA-1291: Make wireguard the default option #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
There was a problem hiding this comment.
Thanks @kp-juan-docal , it looks good to me. I just added some comments about how we can only set this up for iOS
| @@ -225,7 +225,7 @@ extension Client { | |||
| enablesServerPings = false | |||
| minPingInterval = 120000 | |||
|
|
|||
| availableVPNProfiles = [IKEv2Profile()] | |||
| availableVPNProfiles = [] | |||
There was a problem hiding this comment.
Can we apply this update only when the platform is not tvOS?
| @@ -481,7 +495,7 @@ extension Client.Preferences { | |||
| useWiFiProtection = true | |||
| trustCellularData = false | |||
| nmtMigrationSuccess = false | |||
| vpnType = IKEv2Profile.vpnType | |||
| vpnType = PIAWGTunnelProfile.vpnType | |||
There was a problem hiding this comment.
Same as the other comments: for tvOS we still want IKEv2 to be the default
There was a problem hiding this comment.
We need to also have all references to PIAWGTunnelProfile inside the iOS condition since this class is not available on tvOS otherwise it won't compile on tvOS
kp-juan-docal
force-pushed
the
juan.docal/PIA-1291-make-wireguard-the-default-option
branch
from
ca45534
to
18e340f
Compare
There was a problem hiding this comment.
Great job @kp-juan-docal! Just one comment to address in order to have it compile for tvOS as well
kp-juan-docal
force-pushed
the
juan.docal/PIA-1291-make-wireguard-the-default-option
branch
from
18e340f
to
b751e20
Compare
kp-laura-sempere
approved these changes
Feb 8, 2024
kp-juan-docal
deleted the
juan.docal/PIA-1291-make-wireguard-the-default-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It introduces the changes to make wireguard the default protocol on new installations and the logic to allow us to migrate to wireguard those on ikev2 with default settings.
Sanity Testers
Tests were performed with the application changes introduced here