Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accidentally extend implicit eval function #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't accidentally extend implicit eval function #21

wants to merge 1 commit into from

Commits on Oct 17, 2024

  1. Don't accidentally extend implicit eval function 

    This package uses the name `eval`, which is ordinarily reserved for
the implicitly provided `eval` function provided by the core system.
Adding methods to this generic function worked accidentally due to
the way the implementation works, but is probably neither what you
want nor guarateed to keep working (e.g. JuliaLang/julia#55949
would break it if merged). To address the issue, make `Fuzzy` a
baremodule to avoid implicitly creating the `include`/`eval` names
and then add back explicit imports of Base and a definition of `include`.

This way, `Fuzzy.eval` is completely decoupled from the core notion of
`eval`.
    @Keno
    Keno committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ace9c21 View commit details
    Browse the repository at this point in the history