Don't accidentally extend implicit eval
function
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package uses the name
eval
, which is ordinarily reserved for the implicitly providedeval
function provided by the core system. Adding methods to this generic function worked accidentally due to the way the implementation works, but is probably neither what you want nor guarateed to keep working (e.g. JuliaLang/julia#55949 would break it if merged). To address the issue, makeFuzzy
a baremodule to avoid implicitly creating theinclude
/eval
names and then add back explicit imports of Base and a definition ofinclude
.This way,
Fuzzy.eval
is completely decoupled from the core notion ofeval
.