Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nf core branding #9

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Remove nf core branding #9

merged 10 commits into from
Jun 7, 2024

Conversation

sgsutcliffe
Copy link
Collaborator

@sgsutcliffe sgsutcliffe commented Jun 5, 2024

Following the nf-core guidlines for using nf-core templates outside of nf-core: we removed the nf-core branding and updated the README.md to match the nextflow pipeline as is. See nf-core guidlines for more information.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/staramr branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sgsutcliffe sgsutcliffe requested a review from apetkau June 5, 2024 17:45
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @sgsutcliffe , thanks so much 😄 . A few small comments.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steven for the changes. I believe to fix the linting issues you also have to change the pipeline name to phac-nml/staramrnf here: https://github.com/phac-nml/staramrnf/blob/dev/nextflow.config#L223

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much. Looks great to me 😄

@sgsutcliffe sgsutcliffe merged commit bf2d4b7 into dev Jun 7, 2024
4 checks passed
@sgsutcliffe sgsutcliffe deleted the remove-nf-core-branding branch June 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants