-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #18: "schema_input.json" does not accept uncompressed contigs #21
Fixes #18: "schema_input.json" does not accept uncompressed contigs #21
Conversation
To test the change I ran the sample,contigs,species
GCA_000008105,tests/genomes/salmonella/GCA_000008105.1_ASM810v1_genomic.fasta,Salmonella
GCA_000947975,tests/genomes/ecoli/GCA_000947975.1_ASM94797v1_genomic.fa,Escherichia coli
GCF_000196035,tests/genomes/listeria/GCF_000196035.1_ASM19603v1_genomic.fna,Listeria monocytogenes |
I will include one of the uncompressed genomes to use as test for |
The genome file paths in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Steven 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to include this uncompressed fasta file anymore since it's already been pushed to the dev branch. However, it shouldn't cause any issues, and keeping it might actually make merging easier, as the branches will align more closely... up to you 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd made the commit prior to including the uncompressed genome on dev and just decided to do less work i.e. roll back the commit, but it does appear like redundant work 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it all works (e.g., no merge conflicts when merging back into dev
) then you can leave as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Steven. Thanks so much. Just one small change on the error message being printed out (given in-line below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it all works (e.g., no merge conflicts when merging back into dev
) then you can leave as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me. Thanks so much 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Steven.
The input file for running
staramrnf
had a restrictive pattern forcontigs
column in theschema_input.json
such that only compressed files with .gz file extension could be included. To allow for uncompressed files I modified the regex pattern.PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.