-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify input parameters to integrate with IRIDA-Next UI #15
Conversation
…work with IRIDA-Next UI
The first change I made was to change the input column |
…q_1' to work with IRIDA-Next UI" This reverts commit 7f4ddab.
Changing |
… file on IRIDA-Next
The CLI arguments added to match the Galaxy staramr UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Steven. Thanks so much 😄 . I have a few comments below.
I am also wondering if you could add some additional test cases where you adjust some of the parameters and then verify they were properly used in the staramr command. The output file settings.txt
contains a copy of the full command-line string for staramr, so verifying that adjusted parameters for staramr could be done in test cases by reading this file and checking if the first line (the staramr command line) contains a string like e.g., --genome-size-lower-bound 4000000
).
Example settings.txt
:
command_line = staramr search --pointfinder-organism salmonella --genome-size-lower-bound 4000000 file.fasta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks so much @sgsutcliffe 😄 . I have a few additional comments for you.
In addition to changing the MLST default name from "None" to "Automatic" I modified the function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your changes Steven. I have a few more comments for you.
Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all your amazing changes Steven :). One more in-line comment I have below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Thanks so much Steven 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Steven!
One of the main uses of staramrnf will be to be integrated with IRIDA-Next and so I am reformatting the
input
formatting to be properly integrated with IRIDA-Next user-interface. Changes should not impact the function of the pipeline.PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).