-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
penumbra: integration work for new tendermint bindings and [email protected]
#3192
Conversation
We need to adjust our |
I took the path of least resistance to handle |
@erwanor There's a failing CI check that alleges some files need to be committed: https://github.com/penumbra-zone/penumbra/actions/runs/6538666650/job/17756717056?pr=3192
Try as I might, I cannot reproduce that error locally, not even if with shifts in tooling. I suspect it's a caching issue in the CI environment, but haven't been able to resolve. Given the importance of this PR, I suggest we press on and merge it. If the same codegen flapping occurs on other PRs after rebasing, then I'll jump on it and get a fix. |
Thanks for your help debugging this, merging optimistically |
I am indeed seeing the same failure on other rebased PRs. Will look into it tomorrow. |
Matches changes in [0]. Required to unbreak build. [0] penumbra-zone/penumbra#3192
Matches changes in [0]. Bump was not broken, as was the case with Osiris [1], but bumping the dep anyway for consistency across the codebase. [0] penumbra-zone/penumbra#3192 [1] penumbra-zone/osiris#25
Matches changes in [0]. Bump was not broken, as was the case with Osiris [1], but bumping the dep anyway for consistency across the codebase. [0] penumbra-zone/penumbra#3192 [1] penumbra-zone/osiris#25
This PR moves the penumbra codebase to using
[email protected]
,[email protected]
,[email protected]
,[email protected]
,[email protected]
and[email protected]