Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

penumbra: integration work for new tendermint bindings and [email protected] #3192

Merged
merged 17 commits into from
Oct 16, 2023

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Oct 16, 2023

@erwanor
Copy link
Member Author

erwanor commented Oct 16, 2023

We need to adjust our MsgUpdateClient handling to use the ClientState abstraction, merging handling of header update, batch of headers, and misbehavior, see: https://github.com/cosmos/ibc-go/blob/830982adfb4448573f8898bbd07a73d06bff640a/docs/docs/03-light-clients/01-developer-guide/04-updates-and-misbehaviour.md#handling-clientmessages-updates-and-misbehaviour

@erwanor erwanor temporarily deployed to smoke-test October 16, 2023 19:09 — with GitHub Actions Inactive
@erwanor
Copy link
Member Author

erwanor commented Oct 16, 2023

I took the path of least resistance to handle client_message continuing to not support misbehavior submission via MsgUpdateClient. I think that's something we will want to do later, however. I will create a ticket to track this (cc @avahowell).

@conorsch conorsch temporarily deployed to smoke-test October 16, 2023 20:02 — with GitHub Actions Inactive
@conorsch
Copy link
Contributor

@erwanor There's a failing CI check that alleges some files need to be committed: https://github.com/penumbra-zone/penumbra/actions/runs/6538666650/job/17756717056?pr=3192

Finished! Consider running a 'cargo check --release' to confirm builds still work.
Updated 1 path from the index
Updated 1 path from the index
ERROR: protobuf files must be regenerated and committed.
Run this command locally: ./deployments/scripts/protobuf-codegen
These are the files that reported differences:
 M crates/proto/src/gen/penumbra.view.v1alpha1.rs
 M crates/proto/src/gen/penumbra.view.v1alpha1.serde.rs
Error: Process completed with exit code 1.

Try as I might, I cannot reproduce that error locally, not even if with shifts in tooling. I suspect it's a caching issue in the CI environment, but haven't been able to resolve. Given the importance of this PR, I suggest we press on and merge it. If the same codegen flapping occurs on other PRs after rebasing, then I'll jump on it and get a fix.

@erwanor
Copy link
Member Author

erwanor commented Oct 16, 2023

Thanks for your help debugging this, merging optimistically

@erwanor erwanor merged commit 006dd82 into main Oct 16, 2023
7 of 8 checks passed
@erwanor erwanor deleted the erwan/tendermint-34 branch October 16, 2023 21:08
@erwanor erwanor self-assigned this Oct 16, 2023
@conorsch
Copy link
Contributor

If the same codegen flapping occurs on other PRs after rebasing, then I'll jump on it and get a fix.

I am indeed seeing the same failure on other rebased PRs. Will look into it tomorrow.

conorsch added a commit to penumbra-zone/osiris that referenced this pull request Oct 23, 2023
Matches changes in [0]. Required to unbreak build.

[0] penumbra-zone/penumbra#3192
conorsch added a commit to penumbra-zone/galileo that referenced this pull request Oct 23, 2023
Matches changes in [0]. Bump was not broken, as was the case with Osiris
[1], but bumping the dep anyway for consistency across the codebase.

[0] penumbra-zone/penumbra#3192
[1] penumbra-zone/osiris#25
conorsch added a commit to penumbra-zone/galileo that referenced this pull request Oct 23, 2023
Matches changes in [0]. Bump was not broken, as was the case with Osiris
[1], but bumping the dep anyway for consistency across the codebase.

[0] penumbra-zone/penumbra#3192
[1] penumbra-zone/osiris#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 63: Rhea (Web Wallet)
Development

Successfully merging this pull request may close these issues.

2 participants