Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prost 0.12, tonic 0.10. #3078

Closed
hdevalence opened this issue Sep 22, 2023 · 3 comments
Closed

Update to prost 0.12, tonic 0.10. #3078

hdevalence opened this issue Sep 22, 2023 · 3 comments

Comments

@hdevalence
Copy link
Member

This is useful for two reasons:

It looks like prost 0.12 has a Name trait: https://docs.rs/prost/latest/prost/trait.Name.html so we could skip updating all the TYPE_URLs, switch to prost 0.12, and delete all the impls instead of updating them.

Originally posted by @hdevalence in #3077 (comment)

and also, because Tonic 0.10.0 has an add_routes feature that will let us composably build up RPC services defined in each component: https://docs.rs/tonic/latest/tonic/transport/server/struct.Server.html#method.add_routes

This will require pulling all our dependencies over.

@hdevalence
Copy link
Member Author

cosmos/ibc-proto-rs#145

@hdevalence
Copy link
Member Author

@conorsch
Copy link
Contributor

Resolved via #3192. Notably we've not yet implemented:

and also, because Tonic 0.10.0 has an add_routes feature that will let us composably build up RPC services defined in each component: https://docs.rs/tonic/latest/tonic/transport/server/struct.Server.html#method.add_routes

but we're now unblocked from doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 63: Rhea (Web Wallet)
Development

No branches or pull requests

2 participants