Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink instead of copy the mod_def.ww3 input in the cesm_cmeps driver #368

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

dougiesquire
Copy link
Collaborator

The WW3 model definition file input needs to be in the work directory and called mod_def.ww3. Previously this driver looked for a file in the inputs with "mod_def.ww3" in the filename and then copied that file to the work directory. This is bad practice. Now, the name of the file is assumed to be "mod_def.ww3" and this file is symlinked instead. Those setting up the configuration will need to ensure that a file with the right name is included in the inputs (e.g. using a symlink if the original input has a different name).

Closes #365

@pep8speaks
Copy link

pep8speaks commented Sep 29, 2023

Hello @dougiesquire! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-09-29 00:30:14 UTC

@coveralls
Copy link

Coverage Status

coverage: 42.016%. remained the same when pulling 7878fba on dougiesquire:365_cesm_cmeps_ww3_input into 2d16f18 on payu-org:master.

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quickie question to make something clear, otherwise fine to merge if that is not something that can be changed.

payu/models/cesm_cmeps.py Show resolved Hide resolved
@aidanheerdegen
Copy link
Collaborator

Merge away.

@dougiesquire dougiesquire merged commit 7fd5204 into payu-org:master Sep 29, 2023
8 checks passed
@dougiesquire dougiesquire deleted the 365_cesm_cmeps_ww3_input branch September 29, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying input files anti-pattern in CESM_CMEPS driver
4 participants