Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symlink with correct name for WW3 mod_def input #5

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Use symlink with correct name for WW3 mod_def input #5

merged 1 commit into from
Jan 9, 2024

Conversation

dougiesquire
Copy link
Collaborator

See #2 for context/justification. This shouldn't be merged until payu-org/payu#368 is released.

Closes #2

@micaeljtoliveira
Copy link
Contributor

micaeljtoliveira commented Oct 9, 2023 •
edited
Loading

Ups. I tried to fix your branch while you were opening the new PR, without realizing you deleted and recreated the branch. I'll fix it!

@dougiesquire
Copy link
Collaborator Author

Sorry - I wasn't very clear

@micaeljtoliveira
Copy link
Contributor

Actually, I think my changes are the correct ones, as they point to the latest sets of inputs. I do need to create the symlink though.

@micaeljtoliveira
Copy link
Contributor

Done.

@dougiesquire To be clear, I've created a symlink to /g/data/ik11/inputs/access-om3/0.x.0/cime/wav/ww3/ww3a.mod_def.ww3.wwver7.14.230705b, which is actually the latest version of the mod_def input, named mod_def.ww3. The PR changes the configuration to use this symlink.

@micaeljtoliveira micaeljtoliveira added inputs Input data ww3 Related to WW3 labels Oct 10, 2023
@micaeljtoliveira micaeljtoliveira added this to the 0.3.x milestone Oct 10, 2023
@aekiss
Copy link
Contributor

aekiss commented Dec 20, 2023

LGTM - is this ready to merge?

@dougiesquire
Copy link
Collaborator Author

LGTM - is this ready to merge?

The required changes in Payu still haven't been released so I think we need to hold off.

@micaeljtoliveira
Copy link
Contributor

The required Payu changes have finally been released, so I think we can merge.

@micaeljtoliveira micaeljtoliveira merged commit 6834f9d into gmom_jra_wd Jan 9, 2024
@micaeljtoliveira micaeljtoliveira mentioned this pull request Jan 9, 2024
Closed
@micaeljtoliveira micaeljtoliveira deleted the ww3_input_fix branch January 12, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micaeljtoliveira micaeljtoliveira micaeljtoliveira approved these changes

Assignees
No one assigned
Labels
inputs Input data ww3 Related to WW3
Projects
None yet
Milestone
0.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@dougiesquire @micaeljtoliveira @aekiss