-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting MODULEPATH via config.yaml #353
Conversation
So a simple solution could be to add a list of directories to add to the MODULEPATH, e.g.
And in config.yaml the order was
MODULEPATH with remain |
I prefer a list of additional module directories than defining an entire MODULEPATH, however redefining MODULEPATH will have the benefit of a concretised order of directories
|
It could be nice grouping the user-defined environment modules and modules directories together however that would add a breaking change to modules option..
|
Agreed that does sound like nicest option. It is possible to keep backward compatibility by testing the return value of popping the Lines 80 to 82 in c8e7424
|
0e250dc
to
3c5b4b2
Compare
Thanks for that suggestion @aidanheerdegen! I've added that in |
3c5b4b2
to
b9d9454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I do think we should add a few more tests for the additional functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
66c9463
to
4a8805a
Compare
Nothings changed/added, I just squashed the commits so it's a little cleaner |
4a8805a
to
456a6d6
Compare
Add an option to add module directories to MODULEPATH via config.yaml.
Should close #347