-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[benchmarking] Reset to genesis storage after each run #5655
Open
ggwpez
wants to merge
15
commits into
master
Choose a base branch
from
oty-omni-bencher-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+191
−142
Open
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3631111
Set genesis state after each benchmark run
ggwpez a2cc75a
Add test
ggwpez 50ce303
Add PrDoc (auto generated)
ggwpez 6e87e57
Use DEV_RUNTIME_PRESET instead of hard-coding
ggwpez 9aa865f
INSTALL WITH LOCKED FFS
ggwpez 6bb2cb5
Revert "INSTALL WITH LOCKED FFS"
ggwpez c846cf5
Only test in std
ggwpez 8809ce5
omni-bencher: Fix runtime genesis generation
ggwpez a9ec975
Update substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
ggwpez f205230
Update substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
ggwpez 669c88a
Update substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
ggwpez a539e2a
Update substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
ggwpez f641517
Stay backwards compatible
ggwpez 1da1213
Rename to GenesisBuilderPolicy
ggwpez b98d341
Merge branch 'master' into oty-omni-bencher-fix
ggwpez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
title: '[benchmarking] Reset to genesis storage after each run' | ||
doc: | ||
- audience: Runtime Dev | ||
description: |- | ||
The genesis state is currently partially provided via `OverlayedChanges`, but these changes are reset by the runtime after the first repetition, causing the second repitition to use an invalid genesis state. | ||
|
||
Changes: | ||
- Provide the genesis state as a `Storage` without any `OverlayedChanges` to make it work correctly with repetitions. | ||
- Add `--genesis-builder-preset` option to use different genesis preset names. | ||
- Improve error messages. | ||
crates: | ||
- name: frame-benchmarking-cli | ||
bump: minor | ||
- name: frame-benchmarking-pallet-pov | ||
bump: minor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean here that this was overridden and not reset?