[benchmarking] Reset to genesis storage after each run #5655
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This reverts commit 9aa865f.
| doc: | ||
| - audience: Runtime Dev | ||
| description: |- | ||
| The genesis state is currently partially provided via `OverlayedChanges`, but these changes are reset by the runtime after the first repetition, causing the second repitition to use an invalid genesis state. |
There was a problem hiding this comment.
but these changes are reset by the runtime after the first repetition
You mean here that this was overridden and not reset?
| }) | ||
| } | ||
|
|
||
| /// Convert some overlayed changes to a storage. | ||
| fn changes_to_storage<H: Hash>( |
There was a problem hiding this comment.
Why not get rid of all of this and genesis_from_runtime and just use GenesisConfigBuilderRuntimeCaller? It has all the machinery ready and we get rid of the manual json merging stuff too.
There was a problem hiding this comment.
I'd also try using GenesisConfigBuilderRuntimeCaller to have genesis storage building in one place. If something is missing it can be adjusted / reworked.
bkontur
added
the
A4-needs-backport
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
| ), | ||
| "build the genesis spec", | ||
| )?; | ||
| self.genesis_from_code::<EHF>(code) |
There was a problem hiding this comment.
You already got storage. You don't need to call this.
There was a problem hiding this comment.
There is a distinction now between using the Genesis state from the spec, and using the runtime of the spec to build the genesis state through a preset.
This function does the later - hence it generates the state from the genesis runtime.
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
| // Use the runtime from the Spec file to build the genesis state. | ||
| SpecRuntime, | ||
| /// Use the spec file to build the genesis state. This fails when there is no spec. | ||
| Spec, | ||
| SpecGenesis, |
There was a problem hiding this comment.
nit: Maybe better name for this while enum would be GenesisBuilderPolicy?
There was a problem hiding this comment.
Yes sounds better, the original name was a bit random 😅
|
@ggwpez Anything speaks against merging this? I have a follow up that could share some code. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
The genesis state is currently partially provided via
OverlayedChanges, but these changes are reset by the runtime after the first repetition, causing the second repitition to use an invalid genesis state.Changes:
Storagewithout anyOverlayedChangesto make it work correctly with repetitions.--genesis-builder-presetoption to use different genesis preset names.