Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.4 support #872

Closed
wants to merge 14 commits into from
Closed

Add PHP 8.4 support #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ae504e2
Add PHP ~8.4 in composer.json
joanhey Aug 12, 2024
68f701e
Add PHP 8.4 to ci.yml workflow
joanhey Aug 12, 2024
c81a929
Update composer.json with ~8.4.0
joanhey Aug 12, 2024
9ccf6bd
Update composer.json with PHP >=8.2
joanhey Aug 12, 2024
b010d37
Merge branch '7.x' into php8.4.x
joanhey Aug 20, 2024
ae70959
Update composer.json
joanhey Aug 20, 2024
34d2fb1
Update composer.json with patch version too
joanhey Aug 20, 2024
bf05e57
Testing coverage with conditional
joanhey Aug 21, 2024
b4a70a8
Try conditional again
joanhey Aug 21, 2024
9bcf094
Revert conditional
joanhey Aug 21, 2024
c85a603
Merge branch '7.x' into php8.4.x
joanhey Aug 21, 2024
c0b3bee
Merge branch '7.x' into php8.4.x
Slamdunk Sep 25, 2024
77f38be
Raise tests' timeout to 5 minutes
Slamdunk Sep 25, 2024
faebd7e
Raise tests' timeout to 5 minutes (ops)
Slamdunk Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
tools: composer-normalize, composer-require-checker
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "composer validate --strict"
- run: "composer-normalize --dry-run"
Expand All @@ -48,7 +48,7 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- name: "Lint XMLs"
uses: ./.github/lint-xml-configuration
Expand All @@ -64,6 +64,7 @@ jobs:
php-version:
- "8.2"
- "8.3"
- "8.4"
dependencies:
- "lowest"
- "highest"
Expand All @@ -75,12 +76,12 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"
with:
dependency-versions: "${{ matrix.dependencies }}"

- name: "Run tests"
timeout-minutes: 3
timeout-minutes: 5
run: "vendor/bin/phpunit --no-coverage --no-logging"

code-coverage:
Expand All @@ -98,10 +99,10 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- name: "Run tests"
timeout-minutes: 3
timeout-minutes: 5
run: "vendor/bin/phpunit --coverage-xml=coverage/coverage-xml --log-junit=coverage/junit.xml"

- name: "Gather base branch for diff"
Expand Down Expand Up @@ -136,7 +137,7 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
tools: cs2pr
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "vendor/bin/phpcs -q --report=checkstyle | cs2pr"

Expand All @@ -155,6 +156,6 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "vendor/bin/phpstan --memory-limit=512M --ansi --no-progress"
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}
],
"require": {
"php": "~8.2.0 || ~8.3.0",
"php": "~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-dom": "*",
"ext-pcre": "*",
"ext-reflection": "*",
Expand Down
Loading