Add PHP 8.4 support #872
Closed
Add PHP 8.4 support #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always have time to limit before a new final PHP version.
Jean85
requested changes
Aug 20, 2024
"php": "~8.2 || ~8.3 || ~8.4", Constraints limited. Used without the ".0" because have the same effect.
|
I don't like the CI build on 8.4 to be successful: https://github.com/paratestphp/paratest/actions/runs/10473712966/job/29006479710?pr=872#step:3:19
|
Composer.json require pcov.
|
Apparently there's an infinite loop somewhere with PHP 8.4, but I can't debug it yet locally because the pcov PECL extension hasn't been updated yet, we need to wait |
This was referenced Oct 9, 2024
|
Superseded by #898 thank you anyway for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests pass, but show deprecations with the
symfony/stringv5.4.0 class in PHP 8.4 lowest test.Symfony/stringis fixed symfony/string@bce7504PD: perhaps it'll be better to change incomposer.json:with
Changed to
"php": ">=8.2"Fix #871
that break PestPHP pestphp/pest#1199