Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: - The language change button has been updated in terms of UX … #142

Merged
merged 4 commits into from
Oct 18, 2022
Merged

update: - The language change button has been updated in terms of UX … #142

merged 4 commits into from
Oct 18, 2022

Conversation

mouafus
Copy link
Collaborator

@mouafus mouafus commented Oct 15, 2022 •
edited by elhmn
Loading

  • The language change button has been updated in terms of UX and positioning on the homepage and in the drawer
  • Changing the page from the drawer no longer refreshes the browser tab;
  • page 'add-report', we can now open the drawer without any chance of getting the "Cannot POST /add-alert" error
  • error during the build of the "report" icon which was not loaded fixed
  • Translation of drawer contents, add-report page and other contents

This will solve #141

@mouafus
update: - The language change button has been updated in terms of UX …
3547005 
…and positioning on the homepage and in the drawer

- Changing the page from the drawer no longer refreshes the browser tab;
fix: - page 'add-report', we can now open the drawer without any chance of - getting the "Cannot POST /add-alert" error
- error during the build of the "report" icon which was not loaded;
add: - Translation of drawer contents, add-report page and other contents
@elhmn elhmn requested review from Asam237, yokwejuste and godsakani and removed request for yokwejuste October 15, 2022 20:25
@elhmn elhmn linked an issue Oct 15, 2022 that may be closed by this pull request
Open drawer when we are on "add-alert" page #141
Closed
Asam237
Asam237 requested changes Oct 15, 2022
View reviewed changes
frontend/src/components/drawer/Drawer.component.tsx Outdated
const [isOpen, setIsOpen] = useState(false);
const toggleDrawer = () => {
console.log("problem herer");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the console.log

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Asam237
Copy link
Member

Asam237 commented Oct 15, 2022

Great work @mouafus

This was referenced Oct 15, 2022
Closed
Closed
@Asam237 Asam237 self-requested a review October 16, 2022 20:01
mouafus
mouafus commented Oct 17, 2022
View reviewed changes
Copy link
Collaborator Author

@mouafus mouafus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that console.log

@Asam237 Asam237 linked an issue Oct 18, 2022 that may be closed by this pull request
Add pagination #143
Closed
@Asam237 Asam237 merged commit d8f8e8b into osscameroon:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asam237 Asam237 Asam237 approved these changes

@godsakani godsakani Awaiting requested review from godsakani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pagination Open drawer when we are on "add-alert" page
2 participants
@mouafus @Asam237