Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination #143

Closed
Asam237 opened this issue Oct 15, 2022 · 2 comments · Fixed by #142
Closed

Add pagination #143

Asam237 opened this issue Oct 15, 2022 · 2 comments · Fixed by #142
Labels
frontend

Comments

@Asam237
Copy link
Member

Asam237 commented Oct 15, 2022

add a pagination to the city list:

simplescreenrecorder-2022-10-15_22.00.07.mp4

like this:

Screenshot from 2022-10-15 22-05-55
@mouafus
Copy link
Collaborator

mouafus commented Oct 17, 2022

I'm in

@mouafus
Copy link
Collaborator

mouafus commented Oct 17, 2022

@Asam237 i think the best wait to paginate call and API endpoint with the page and the per_page. Is not a good idea to make the pagination with all data in front

@mouafus mouafus mentioned this issue Oct 17, 2022
Merged
2 tasks
@Asam237 Asam237 linked a pull request Oct 18, 2022 that will close this issue
update: - The language change button has been updated in terms of UX … #142
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update: - The language change button has been updated in terms of UX … mouafus/onacut
2 participants
@Asam237 @mouafus