Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for FTheoryTools #4219

Merged

[FTheoryTools] Serialize resolutions

30582f4
Select commit
Loading
Failed to load commit list.
Merged

Minor improvements for FTheoryTools #4219

[FTheoryTools] Serialize resolutions
30582f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 1s

84.58% (-0.02%) compared to f55951b

View this Pull Request on Codecov

84.58% (-0.02%) compared to f55951b

Details

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (f55951b) to head (30582f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...eoryTools/src/Serialization/hypersurface_models.jl 35.71% 9 Missing ⚠️
...heoryTools/src/Serialization/weierstrass_models.jl 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
- Coverage   84.60%   84.58%   -0.02%     
==========================================
  Files         631      631              
  Lines       84946    84982      +36     
==========================================
+ Hits        71865    71883      +18     
- Misses      13081    13099      +18     
Files with missing lines Coverage Δ
...ntal/FTheoryTools/src/Serialization/tate_models.jl 98.07% <100.00%> (+0.57%) ⬆️
...eoryTools/src/Serialization/hypersurface_models.jl 82.69% <35.71%> (-17.31%) ⬇️
...heoryTools/src/Serialization/weierstrass_models.jl 80.76% <35.71%> (-16.74%) ⬇️