Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for FTheoryTools #4219

Merged

Conversation

HereAround
Copy link
Member

If nothing unexpected happens, then this PR should:

  • Remove wrong and unused final 3 blowups for the big model.
  • Serialize the resolutions.

cc @apturner @emikelsons

@HereAround HereAround marked this pull request as ready for review October 18, 2024 15:09
Copy link
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, thanks @HereAround.

@HereAround HereAround enabled auto-merge (rebase) October 18, 2024 15:47
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (f55951b) to head (30582f4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...eoryTools/src/Serialization/hypersurface_models.jl 35.71% 9 Missing ⚠️
...heoryTools/src/Serialization/weierstrass_models.jl 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
- Coverage   84.60%   84.58%   -0.02%     
==========================================
  Files         631      631              
  Lines       84946    84982      +36     
==========================================
+ Hits        71865    71883      +18     
- Misses      13081    13099      +18     
Files with missing lines Coverage Δ
...ntal/FTheoryTools/src/Serialization/tate_models.jl 98.07% <100.00%> (+0.57%) ⬆️
...eoryTools/src/Serialization/hypersurface_models.jl 82.69% <35.71%> (-17.31%) ⬇️
...heoryTools/src/Serialization/weierstrass_models.jl 80.76% <35.71%> (-16.74%) ⬇️

@HereAround HereAround merged commit 6ffb98e into oscar-system:master Oct 18, 2024
29 checks passed
@HereAround HereAround deleted the MinorImprovementsFTheoryTools branch October 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants