test: fix the testcase strings to not include osinfo_template
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinv
reviewed
Oct 24, 2024
Thank you, that is an excellent suggestion, I updated the code based on your suggestion (will probably have to force push again and if you don't mind squash) because I think the linter will not be happy. |
mvo5
force-pushed
the
fix-testcase-strs
branch
from
f619a1a
to
f8d8a1b
Compare
|
@mvo5 why do you removed my suggestion? wasn't it working? |
|
Merge conflict :( |
mvo5
force-pushed
the
fix-testcase-strs
branch
from
cb29968
to
88396f7
Compare
This commit fixes the testcase string representation to not include
the `osinfo_template` string and adds a test case to not accidentally
regress here. Currently our test case strings look like:
```
<Dir bootc-image-builder>
<Dir test>
<Module test_build.py>
<Function test_container_builds>
<Function test_image_is_generated[quay.io/centos-bootc/centos-bootc:stream9,qcow2+raw+vmdk+vhd+gce,CentOS Stream 9 ({arch})]>
<Function test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch})]>
...
```
which is an accident. A testcase should ideally only contain what
Instead of putting the osinfo_template into the testcase itself,
have a function that generates it. It has downsides (now the
osinfo_template is more disconnected from the testcase) so we could
move it also back into testcase or we could exclude osinfo_template
from the string generation. Ideas welcome here, my current approach
feels okay but not like it's perfect yet.
mvo5
force-pushed
the
fix-testcase-strs
branch
from
88396f7
to
5ded3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the testcase string representation to not include the
osinfo_templatestring and adds a test case to not accidentally regress here. Currently our test case strings look like:which is an accident (not the {arch} part in the output above). A testcase should ideally only contain what
Instead of putting the osinfo_template into the testcase itself, have a function that generates it. It has downsides (now the osinfo_template is more disconnected from the testcase) so we could move it also back into testcase or we could exclude osinfo_template from the string generation. Ideas welcome here, my current approach feels okay but not like it's perfect yet.