Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop removed packages from CentOS Stream 10 and RHEL 10. #696

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

achilleas-k
Copy link
Member

data/defs/centos-10: drop removed packages

These packages are no longer part of CentOS Stream 10 (or RHEL 10).


test: run tests with centos-bootc:stream10 as well

Rename TestCaseCentos to TestCaseS9S and add a TestCaseC10S.


These packages are no longer part of CentOS Stream 10 (or RHEL 10).
Rename TestCaseCentos to TestCaseS9S and add a TestCaseC10S.
Copy link
Member

@henrywang henrywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@achilleas-k
Copy link
Member Author

osinfo-detect on the C10S ISO just returns

Media is bootable.

which is making a test fail. I don't know if that's a bug or something we should change in tests.

@achilleas-k
Copy link
Member Author

osinfo-detect on the C10S ISO just returns

Media is bootable.

which is making a test fail. I don't know if that's a bug or something we should change in tests.

@mmartinv I assume this depends on the version of libosinfo and what distro versions it knows about. Would it make sense to skip (or adapt) the test for CentOS Stream 10 or should this be working already?

@mmartinv
Copy link
Contributor

osinfo-detect on the C10S ISO just returns

Media is bootable.

which is making a test fail. I don't know if that's a bug or something we should change in tests.

@mmartinv I assume this depends on the version of libosinfo and what distro versions it knows about. Would it make sense to skip (or adapt) the test for CentOS Stream 10 or should this be working already?

It looks like CentOS Stream 10 is not in osinfo-db (because it's not release yet I guess..): https://gitlab.com/libosinfo/osinfo-db/-/tree/main/data/os/centos.org?ref_type=heads

@mmartinv
Copy link
Contributor

@achilleas-k this PR will conflict with #680. I like the of moving the osinfo_template logic to a function instead of putting it on each test case.

@achilleas-k
Copy link
Member Author

achilleas-k commented Oct 31, 2024

@achilleas-k this PR will conflict with #680. I like the of moving the osinfo_template logic to a function instead of putting it on each test case.

Right. Let's get that one in first then and I'll adapt this one accordingly.

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants