-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Extend test coverage of openQA::Git #5851
Closed
r-richardson
wants to merge
3
commits into
os-autoinst:master
from
r-richardson:refactor_use_openqa_git
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Copyright SUSE LLC | ||
# SPDX-License-Identifier: GPL-2.0-or-later | ||
|
||
use Test::Most; | ||
use Test::Warnings ':report_warnings'; | ||
use Test::MockModule; | ||
use Test::MockObject; | ||
use FindBin; | ||
use lib "$FindBin::Bin/lib", "$FindBin::Bin/../external/os-autoinst-common/lib"; | ||
use OpenQA::Test::TimeLimit '10'; | ||
use OpenQA::Git; | ||
|
||
my $mock = Test::MockModule->new('OpenQA::Utils'); | ||
$mock->redefine('run_cmd_with_log_return_error', sub { | ||
my ($cmd) = @_; | ||
|
||
if ($cmd->[1] eq 'push') { | ||
# Simulate a failure when attempting to push | ||
return { status => 0 }; | ||
} | ||
# Simulate success for other git commands ('add', 'commit') | ||
return { status => 1 }; | ||
}); | ||
|
||
my $mock_app = Test::MockObject->new(); | ||
$mock_app->set_always('config', { | ||
'global' => { 'scm' => 'git' }, | ||
'scm git' => { 'do_push' => 'yes' } | ||
}); | ||
|
||
my $mock_user = Test::MockObject->new(); | ||
$mock_user->set_always('fullname', 'Test User'); | ||
$mock_user->set_always('email', '[email protected]'); | ||
|
||
my $git = OpenQA::Git->new(app => $mock_app, dir => '.', user => $mock_user); | ||
|
||
my $result = $git->commit({ | ||
add => ['t/16-utils-git.t'], | ||
message => 'Test commit message', | ||
}); | ||
|
||
is $result, 'Unable to push Git commit', 'Commit method correctly handles push failure'; | ||
|
||
done_testing; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at t/16-utils-runcmd.t
run_cmd_with_log_return_error
is an imported function, so it is already defined in OpenQA::Git when you create the OpenQA::Util mock.Just do it like in t/16-utils-runcmd.t
Maybe the tests from there should be moved to your new test?
It would be a bit weird to have them in separate files.