WIP Extend test coverage of openQA::Git #5851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/Contributing.asciidoc already suggests to setup the test database manually or run tests with `KEEP_DB=1` to make development more efficient. We can make this process even easier to discover and use by extracting a make target "setup-database".
perlpunk
reviewed
Aug 13, 2024
| use OpenQA::Git; | ||
|
|
||
| my $mock = Test::MockModule->new('OpenQA::Utils'); | ||
| $mock->redefine('run_cmd_with_log_return_error', sub { |
There was a problem hiding this comment.
Have a look at t/16-utils-runcmd.t
run_cmd_with_log_return_error is an imported function, so it is already defined in OpenQA::Git when you create the OpenQA::Util mock.
Just do it like in t/16-utils-runcmd.t
Maybe the tests from there should be moved to your new test?
It would be a bit weird to have them in separate files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get openQA::Git test coverage to 100% though its not working yet. My test is currently still running commit and push on my actual git dev branch even though i mocked
run_cmd_with_log_return_error(which is used by openQA::Git) to simply return success or failures. I've also tried using set_series for the MockObject instead but that did not help so far