Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve commenting on test results overview according to feedback #5542

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Improve commenting on test results overview according to feedback #5542

merged 3 commits into from
Mar 22, 2024

Commits on Mar 22, 2024

  1. Rename "Batch commenting" to "Add comments" according to feedback 

    See https://progress.opensuse.org/issues/154261
    @Martchus
    Martchus committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e52c5fc View commit details
    Browse the repository at this point in the history

  2. Suggest reloading page after adding comments on overview page 

    As suggested by feedback, see
https://progress.opensuse.org/issues/154261#note-17.
    @Martchus
    Martchus committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    45179ab View commit details
    Browse the repository at this point in the history

  3. Hide commenting button on empty test results overview pages 

    The attempt to add comments for an empty set of jobs would only run into a
parameter validation error anyway, see
https://progress.opensuse.org/issues/154261#note-17.
    @Martchus
    Martchus committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    32d4fd3 View commit details
    Browse the repository at this point in the history