Improve commenting on test results overview according to feedback #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by feedback, see https://progress.opensuse.org/issues/154261#note-17.
The attempt to add comments for an empty set of jobs would only run into a parameter validation error anyway, see https://progress.opensuse.org/issues/154261#note-17.
okurz
approved these changes
Mar 22, 2024
perlpunk
approved these changes
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 391 391
Lines 38039 38039
=======================================
Hits 37427 37427
Misses 612 612 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages and https://progress.opensuse.org/issues/154261