Allow searching for jobs by comment text

assets/javascripts/tests.js

@@ -245,7 +245,7 @@ function renderTestLists() {
       this[paramName] = paramValues[0];
     }
   };
-  jQuery.each(['limit', 'groupid', 'match', 'group_glob', 'not_group_glob'], (index, paramName) => {
+  jQuery.each(['limit', 'groupid', 'match', 'group_glob', 'not_group_glob', 'comment'], (index, paramName) => {
     ajaxQueryParams.addFirstParam(paramName);
   });
   delete ajaxQueryParams.addFirstParam;

lib/OpenQA/Schema/ResultSet/Jobs.pm

@@ -299,6 +299,10 @@ sub _prepare_complex_query_search_args ($self, $args) {
         }
     }
 
+    if (defined(my $c = $args->{comment_text})) {
+        push @conds, \["(select id from comments where job_id = me.id and text like ? limit 1) is not null", "%$c%"];
+    }
+
     push(@conds, @{$args->{additional_conds}}) if $args->{additional_conds};
     my %attrs;
     $attrs{columns} = $args->{columns} if $args->{columns};

lib/OpenQA/WebAPI/Controller/Test.pm

@@ -135,6 +135,7 @@ sub list_ajax ($self) {
         state => [OpenQA::Jobs::Constants::FINAL_STATES],
         scope => $scope,
         match => $self->get_match_param,
+        comment_text => $self->param('comment'),
         groupids => $self->_prepare_groupids,
         limit => min(
             $limits->{all_tests_max_finished_jobs},
@@ -214,6 +215,7 @@ sub list_running_ajax {
     my $running = $self->schema->resultset('Jobs')->complex_query(
         state => [OpenQA::Jobs::Constants::EXECUTION_STATES],
         match => $self->get_match_param,
+        comment_text => $self->param('comment'),
         groupid => $self->param('groupid'),
         order_by => [{-desc => 'me.t_started'}, {-desc => 'me.id'}],
         columns => [
@@ -261,6 +263,7 @@ sub list_scheduled_ajax {
     my $scheduled = $self->schema->resultset('Jobs')->complex_query(
         state => [OpenQA::Jobs::Constants::PRE_EXECUTION_STATES],
         match => $self->get_match_param,
+        comment_text => $self->param('comment'),
         groupid => $self->param('groupid'),
         order_by => [{-desc => 'me.t_created'}, {-desc => 'me.id'}],
         columns => [

lib/OpenQA/WebAPI/Plugin/Helpers.pm

@@ -396,6 +396,7 @@ sub _compose_job_overview_search_args ($c) {
 
     my $v = $c->validation;
     $v->optional($_, 'not_empty') for JOBS_OVERVIEW_SEARCH_CRITERIA;
+    $v->optional('comment');
     $v->optional('groupid')->num(0, undef);
     $v->optional('modules', 'comma_separated');
     $v->optional('limit', 'not_empty')->num(0, undef);
@@ -488,6 +489,9 @@ sub _compose_job_overview_search_args ($c) {
     # allow filtering by group ID or group name
     $search_args{groupids} = [map { $_->id } @groups] if @groups;
 
+    # allow filtering by comment text
+    $search_args{comment_text} = $v->param('comment');
+
     return (\%search_args, \@groups);
 }
 

t/10-tests_overview.t

@@ -23,6 +23,7 @@ sub get_summary { OpenQA::Test::Case::trim_whitespace($t->tx->res->dom->at('#sum
 
 my $jobs = $schema->resultset('Jobs');
 $jobs->find(99928)->update({blocked_by_id => 99927});
+$jobs->find($_)->comments->create({text => 'foobar', user_id => 99901}) for 99946, 99963;
 $t->get_ok('/tests/overview' => form => {distri => 'opensuse', version => '13.1', build => '0091'})->status_is(200);
 
 my $summary = get_summary;
@@ -346,6 +347,13 @@ like(get_summary, qr/current time Failed: 1$/i);
 $t->element_exists('#res_DVD_x86_64_doc .result_failed', 'job with failed module logpackages still shown');
 $t->element_exists_not('#res_DVD_x86_64_kde .result_passed', 'passed job hidden');
 
+subtest 'comment parameter' => sub {
+    $t->get_ok('/tests/overview?groupid=1001&distri=opensuse&version=13.1&build=0091&comment=oob');
+    $t->status_is(200);
+    my $ids = $t->tx->res->dom->find('.overview span[id^="res-"]')->map(attr => 'id')->sort->to_array;
+    is_deeply $ids, [qw(res-99946 res-99963)], 'expected set of jobs present';
+};
+
 # Check if another random module has failed
 $latest_job->update({DISTRI => 'opensuse'});
 my $failing_module = $schema->resultset('JobModules')->create(

t/ui/01-list.t

@@ -424,13 +424,22 @@ subtest 'filter-finished' => sub {
     cmp_ok scalar $driver->find_elements('#results tbody tr', 'css'), '>', scalar @jobs, 'all jobs shown again';
 };
 
-$driver->get('/tests?match=staging_e');
-wait_for_ajax();
+subtest 'match parameter' => sub {
+    $driver->get('/tests?match=staging_e');
+    wait_for_ajax msg => '"All tests" with match parameter';
+    @jobs = map { $_->get_attribute('id') } @{$driver->find_elements('tbody tr', 'css')};
+    ok !$jobs[0], 'no running job matching';
+    ok !$jobs[1], 'no scheduled job matching';
+    is $jobs[2], 'job_99926', 'exactly one finished job matching';
+};
 
-@jobs = map { $_->get_attribute('id') } @{$driver->find_elements('tbody tr', 'css')};
-ok !$jobs[0], 'no running job matching';
-ok !$jobs[1], 'no scheduled job matching';
-is $jobs[2], 'job_99926', 'exactly one finished job matching';
+subtest 'comment parameter' => sub {
+    $driver->get('/tests?comment=test1');
+    wait_for_ajax msg => '"All tests" with comment parameter';
+    is_deeply [map { $_->get_attribute('id') } @{$driver->find_elements('tbody tr', 'css')}],
+      [qw(job_99963 job_99928 job_99946)],
+      'exactly one running, scheduled and finished job match';
+};
 
 $driver->get('/tests');
 wait_for_ajax();