Allow searching for jobs by comment text #5425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works exactly like the `match` parameter and is also implemented as part of the complex query function. I tested the performance locally with a dump of the OSD database. Here it takes around 1.5 seconds to load the finished jobs on the "All tests" page. When adding `?comment=poo` the time goes up to around 3.4 seconds. When specifying a comment parameter so that only a few jobs are returned like `?comment=poo%23119515` the time is even a bit lower (here 2.2 seconds for this example). This test means the lookup speed has more than doubled when the `comment` parameter is used. However, it is still acceptably low for the default limit of 500 jobs. Related ticket: https://progress.opensuse.org/issues/151402
kraih
reviewed
Jan 15, 2024
The same as the previous commit did for the "All tests" page. Related ticket: https://progress.opensuse.org/issues/151402
Martchus
force-pushed
the
comment-search
branch
from
f8f8dc7
to
c2c838f
Compare
perlpunk
approved these changes
Jan 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37709 37724 +15
=======================================
+ Hits 37097 37112 +15
Misses 612 612 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
LGTM as is. You can consider adding a small help text like in
openQA/templates/webapi/test/list.html.ep
Line 48 in 69e8e80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See particular commit messages and https://progress.opensuse.org/issues/151402