Add job group filter options for /tests/overview #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5388 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 389 389
Lines 37454 37490 +36
=======================================
+ Hits 36840 36876 +36
Misses 614 614 ☔ View full report in Codecov by Sentry. |
|
This is what the new include and exclude filter options look like, both are comma separated lists of globs: |
kraih
commented
Dec 6, 2023
| <%= help_popover('Help for the <em>Include job group</em> filter' => ' | ||
| <p>Shows jobs from job groups matching these globs</p>') %> | ||
| <input name="group_glob" type="text" id="group-glob" | ||
| placeholder="globs, comma separated, e.g. *kernel*,*Tumbleweed*" |
There was a problem hiding this comment.
The default globs are not very creative, there's probably better ones to show. 🤔
|
While i've only really used the zero or more character syntax in tests, there's other options as well: https://metacpan.org/pod/Text::Glob#SYNTAX |
perlpunk
approved these changes
Dec 6, 2023
okurz
reviewed
Dec 7, 2023
This change introduces Text::Glob as a new dependency. Because globs are much safer for user provided input than regular expressions, which are prone to ReDoS attacks. Progress: https://progress.opensuse.org/issues/134933
kraih
force-pushed
the
k/job_group_filters
branch
from
aabf9da
to
1505a6a
Compare
Martchus
approved these changes
Dec 7, 2023
kraih
added a commit
that referenced
this pull request
Dec 21, 2023
Based on #5388, and reusing most of the same logic, to bring job group filtering to `/tests` from `/tests/overview`. Similar to the `?match=...` option, this does not have a UI element yet and can only be used by manually entering the query parameter. Since the question of how to extend the filter form with text fields is still open, i consider it out of scope for this PR. Progress: https://progress.opensuse.org/issues/134933
kraih
added a commit
that referenced
this pull request
Dec 22, 2023
Based on #5388, and reusing most of the same logic, to bring job group filtering to `/tests` from `/tests/overview`. Similar to the `?match=...` option, this does not have a UI element yet and can only be used by manually entering the query parameter. Since the question of how to extend the filter form with text fields is still open, i consider it out of scope for this PR. Progress: https://progress.opensuse.org/issues/134933
kraih
added a commit
that referenced
this pull request
Dec 22, 2023
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id `0`. Progress: https://progress.opensuse.org/issues/134933
kraih
added a commit
that referenced
this pull request
Dec 22, 2023
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id `0`. Progress: https://progress.opensuse.org/issues/134933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces Text::Glob as a new dependency. Because globs are much safer for user provided input than regular expressions, which are prone to ReDoS attacks.
Progress: https://progress.opensuse.org/issues/134933