Add group filter options for /tests #5401
Conversation
kraih
force-pushed
the
k/test_group_filters
branch
2 times, most recently
from
b953c0b
to
66a6b30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5401 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37548 37613 +65
=======================================
+ Hits 36936 37001 +65
Misses 612 612 ☔ View full report in Codecov by Sentry. |
kraih
force-pushed
the
k/test_group_filters
branch
from
66a6b30
to
b1c6766
Compare
|
Naming is at least consistent with the other PR. |
Where and in what form? I believe the |
That is correct. How about to mention them all as hover text on the "Search:" label like visible on https://openqa.opensuse.org/tests/ ? |
Sure, but not in this PR. I do not want to touch unrelated features here and create a scope creep situation. |
Based on #5388, and reusing most of the same logic, to bring job group filtering to `/tests` from `/tests/overview`. Similar to the `?match=...` option, this does not have a UI element yet and can only be used by manually entering the query parameter. Since the question of how to extend the filter form with text fields is still open, i consider it out of scope for this PR. Progress: https://progress.opensuse.org/issues/134933
kraih
force-pushed
the
k/test_group_filters
branch
from
b1c6766
to
69e8e80
Compare
|
I've expanded the tooltip at the bottom of |
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id `0`. Progress: https://progress.opensuse.org/issues/134933
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id `0`. Progress: https://progress.opensuse.org/issues/134933
Based on #5388, and reusing most of the same logic, to bring job group filtering to
/testsfrom/tests/overview. Similar to the?match=...option, this does not have a UI element yet and can only be used by manually entering the query parameter. Since the question of how to extend the filter form with text fields is still open, i consider it out of scope for this PR.Progress: https://progress.opensuse.org/issues/134933