-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add support for Nvme/TLS connection #398
Conversation
590b1b3
to
4d26aac
Compare
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 76.05% 76.06%
=======================================
Files 37 37
Lines 3571 3572 +1
=======================================
+ Hits 2716 2717 +1
Misses 772 772
Partials 83 83
|
waiting on opiproject/opi-api#308 |
ff25ceb
to
b524ac4
Compare
583eef1
to
5ce1aad
Compare
docker-compose.yml
Outdated
@@ -16,6 +16,7 @@ services: | |||
- "9009:9009" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document ports better:
- 4444 our default spdk no tls before any RPC is available (compose setting for sanity check)
- 5555 our default spdk with tls before any RPC is available (compose setting for sanity check)
- 7777 from cmdline arguments when starting bridge, should be replaced by API change feat(storage): frontend traget case API opi-api#375
5ee1ab2
to
41a31f3
Compare
Signed-off-by: Boris Glimcher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Boris Glimcher [email protected]