Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage/backend): enable Nvme/TCP TLS PSK encryption. #319

Conversation

artek-koltun
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #319 (f2f8ca8) into main (d007614) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #319      +/-   ##
========================================
- Coverage   7.94%   7.92%   -0.02%     
========================================
  Files         13      13              
  Lines       2039    2043       +4     
========================================
  Hits         162     162              
- Misses      1859    1863       +4     
  Partials      18      18              
Files Coverage Δ
storage/backend.go 0.00% <0.00%> (ø)

@artek-koltun artek-koltun force-pushed the feat-enable-storage-backend-nvme-tcp-encryptio-tests branch from 5c763b4 to f2f8ca8 Compare September 28, 2023 07:46
@artek-koltun artek-koltun marked this pull request as ready for review September 28, 2023 11:55
@artek-koltun artek-koltun requested a review from a team as a code owner September 28, 2023 11:55
@artek-koltun artek-koltun changed the title test(storage/backend): enable Nvme/TCP TLS encryption. test(storage/backend): enable Nvme/TCP TLS PSK encryption. Sep 28, 2023
@artek-koltun artek-koltun marked this pull request as draft September 28, 2023 14:12
@glimchb
Copy link
Member

glimchb commented Sep 28, 2023

dup with #242 ? why /tmp is mapped ?

@glimchb glimchb added the duplicate This issue or pull request already exists label Sep 28, 2023
@glimchb
Copy link
Member

glimchb commented Sep 28, 2023

depends on opiproject/opi-spdk-bridge#398

@artek-koltun
Copy link
Collaborator Author

why /tmp is mapped ?

you correctly identified it here opiproject/opi-spdk-bridge#677 (comment)

dup with #242 ?

Closing as duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants