Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/backend): adjust nvme to parent member. #410

Merged

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Dec 12, 2023

Continuation of opiproject/opi-api#412

CI test fails since we use opi-spdk-bridge from the main branch, which does not contain api update yet

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (f0d182f) 37.00% compared to head (9f776b3) 36.84%.

Files Patch % Lines
storage/resource.go 0.00% 11 Missing ⚠️
storage/backend.go 0.00% 10 Missing ⚠️
storage/goopicsi.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   37.00%   36.84%   -0.17%     
==========================================
  Files          19       19              
  Lines        2289     2299      +10     
==========================================
  Hits          847      847              
- Misses       1409     1419      +10     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun merged commit 6bfed82 into opiproject:main Jan 18, 2024
15 of 18 checks passed
@artek-koltun
Copy link
Collaborator Author

artek-koltun commented Jan 18, 2024

merged to break the circular dependency until it is being discussed how to overcome it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants