Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/backend): adjust nvme to parent member #837

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Dec 12, 2023

Continuation of opiproject/opi-api#412

  1. Merge godpu api update fix(storage/backend): adjust nvme to parent member. godpu#410
  2. Specify a new godpu image number in docker-compose.
  3. Merge this patch

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (1fc498e) 75.44% compared to head (42ccd40) 75.02%.

Files Patch % Lines
pkg/utils/resource.go 0.00% 19 Missing ⚠️
pkg/backend/nvme_path.go 83.33% 3 Missing ⚠️
pkg/backend/nvme_controller.go 33.33% 2 Missing ⚠️
pkg/backend/nvme_path_validate.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   75.44%   75.02%   -0.43%     
==========================================
  Files          40       40              
  Lines        3673     3699      +26     
==========================================
+ Hits         2771     2775       +4     
- Misses        818      839      +21     
- Partials       84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun force-pushed the fix-parents-in-nvme-backend branch 2 times, most recently from bfdae20 to 42ccd40 Compare January 18, 2024 07:38
Signed-off-by: Artsiom Koltun <[email protected]>
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - matches part of what I had been working also :-)

@sandersms sandersms merged commit 457e5eb into opiproject:main Jan 18, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants