You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customize the wallet to allow inline style of displaying error/warning messages on Input PIN screens
This will be a non-default behaviour through an injectable
Note for reviewers
Removed the App.tsx file in packages/legacy/app since its not being used and it might be confusing for developers
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
Updated documentation as needed for changed code and new or modified features;
Added sufficient tests so that overall code coverage is not reduced.
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.
PR template adapted from the Python attrs project.
Can the inline error message be configurable so that it can also appear below the text input? BC's design system specifies that the error/help text is below:
The reason will be displayed to describe this comment to others. Learn more.
Just one small organizational nitpick. As a side note, did you find it to be a hassle keeping the modal style errors as an option? I wonder if it would be better to just go all in on inline errors.
Just one small organizational nitpick. As a side note, did you find it to be a hassle keeping the modal style errors as an option? I wonder if it would be better to just go all in on inline errors.
I believe inline errors is the norm and should be the default. I believe we should use react-forms and some validation library like zod.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jleach
changed the title
bryce-mcmath
added
do not merge
MosCD3
requested review from
bryce-mcmath
and removed request for
bryce-mcmath
Summary of Changes
Customize the wallet to allow inline style of displaying error/warning messages on Input PIN screens
This will be a non-default behaviour through an injectable
Note for reviewers
Removed the
App.tsxfile inpackages/legacy/appsince its not being used and it might be confusing for developersA video demonstration here
Screen.Recording.2024-09-09.at.10.01.33.AM.mov
Related Issues
Related to Issue: #1251
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.