Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inline error messages for pin enter screen #1294

Conversation

FarjadGov14
Copy link
Contributor

@FarjadGov14 FarjadGov14 commented Oct 22, 2024

Summary of Changes

  • add inline error messages for PINEnter screen
  • modify the toggleButton colour use for when its enabled, a quick fix from last PR
  • add locale for english and french
  • fix the border colour for PINInput component

Related Issues

Previous PRs for bifold that are linked to it

Screen recording

Screen_Recording_20241021_222409_Aries.Bifold.mp4

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@MosCD3
Copy link
Contributor

MosCD3 commented Oct 23, 2024

This conflicts with #1253

Copy link

sonarcloud bot commented Oct 23, 2024

@bryce-mcmath bryce-mcmath self-requested a review October 23, 2024 23:50
@bryce-mcmath bryce-mcmath added the do not merge Don't merge when label present label Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (f475eed) to head (5ca30a8).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/legacy/core/App/screens/PINEnter.tsx 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   57.12%   57.00%   -0.12%     
==========================================
  Files         204      207       +3     
  Lines        6980     7075      +95     
  Branches     1978     2001      +23     
==========================================
+ Hits         3987     4033      +46     
- Misses       2971     3020      +49     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be in conflict with another PR by Mostafa, so I will review more thoroughly once you two decide which one should be kept, but I have one comment that will have to be addressed either way.

Comment on lines 53 to +54
...PINInputTheme.cell,
borderColor: PINInputTheme.cell.backgroundColor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this is a good opportunity to add a PINInputTheme.codeFieldRoot field since Bifold users have a need to style it for theming and it is a separate element from the cell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryce-mcmath @MosCD3 I will close my PR as it conflicts with Mostafa's PR. However, this change in PINInput particularly, I will make changes to in separate PR @bryce-mcmath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge when label present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants