-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline error messages for pin enter screen #1294
feat: add inline error messages for pin enter screen #1294
Conversation
Signed-off-by: FarjadGov14 <[email protected]>
This conflicts with #1253 |
Signed-off-by: FarjadGov14 <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 57.12% 57.00% -0.12%
==========================================
Files 204 207 +3
Lines 6980 7075 +95
Branches 1978 2001 +23
==========================================
+ Hits 3987 4033 +46
- Misses 2971 3020 +49
Partials 22 22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be in conflict with another PR by Mostafa, so I will review more thoroughly once you two decide which one should be kept, but I have one comment that will have to be addressed either way.
...PINInputTheme.cell, | ||
borderColor: PINInputTheme.cell.backgroundColor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is a good opportunity to add a PINInputTheme.codeFieldRoot
field since Bifold users have a need to style it for theming and it is a separate element from the cell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryce-mcmath @MosCD3 I will close my PR as it conflicts with Mostafa's PR. However, this change in PINInput particularly, I will make changes to in separate PR @bryce-mcmath
Summary of Changes
Related Issues
Previous PRs for bifold that are linked to it
Screen recording
Screen_Recording_20241021_222409_Aries.Bifold.mp4
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.