Use cifmw_architecture_scenario to set proper automation file #2292
Conversation
openstack-k8s-operators/architecture#375 splits the default vars into different scenario files. We need to fix the reproducer to adapt this change. This pull-request uses cifmw_architecture_scenario to set proper automation file. It drops cifmw_arch_automation_file params from scenario files. Depends-On: openstack-k8s-operators/architecture#375 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
/approve self-approving. This is the 1:1 match of @raukadah patch that got merged slightly too fast. Keeping it as draft to ensure it doesn't merge before we've been able to test all the things. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
I can confirm this change has passed on VAHCI, VA2, OSASinfra and BGP, We are good to merge it. |
|
/override rdoproject.org/github-check
|
|
@cjeanner: Overrode contexts on behalf of cjeanner: rdoproject.org/github-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
deleted the
automation/architecture-scenario-file
branch
Drop default.yaml file #375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2292 Reviewed-by: Cédric Jeanneret
After a recent change [1] we define the architecture automation to be used in the reproducer, based on the VA used. The HCI VA crc job does not use the reproducer role, so it does not get that parameter defined, thus we need to add it to the job definition. [1] #2292
After a recent change [1] we define the architecture automation to be used in the reproducer, based on the VA used. The HCI VA crc job does not use the reproducer role, so it does not get that parameter defined, thus we need to add it to the job definition. [1] #2292
After a recent change [1] we define the architecture automation to be used in the reproducer, based on the VA used. The HCI VA crc job does not use the reproducer role, so it does not get that parameter defined. Set a default value for cifmw_architecture_automation_file in the deploy-architecture playbook for the cases where the reproducer role was not called before and the var is undefined. [1] #2292
After a recent change [1] we define the architecture automation to be used in the reproducer, based on the VA used. The HCI VA crc job does not use the reproducer role, so it does not get that parameter defined. Set a default value for cifmw_architecture_automation_file in the deploy-architecture playbook for the cases where the reproducer role was not called before and the var is undefined. [1] #2292
openstack-k8s-operators/architecture#375 splits
the default vars into different scenario files. We need to fix the
reproducer to adapt this change.
This pull-request uses cifmw_architecture_scenario to set proper automation file.
It drops cifmw_arch_automation_file params from scenario files.
Depends-On: openstack-k8s-operators/architecture#375
Signed-off-by: Chandan Kumar (raukadah) [email protected]