-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop default.yaml file #383
Drop default.yaml file #383
Conversation
Build failed (gate pipeline). For information on how to proceed, see https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ca905ca78374f288a4930da73460e92 Warning: |
/hold let's get tests done. |
openstack-k8s-operators#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
5f80735
to
d52413e
Compare
/hold cancel |
/retest ci/prow/unit |
@cjeanner: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override unit |
@cjeanner: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/unit |
@cjeanner: Overrode contexts on behalf of cjeanner: ci/prow/unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
recheck |
/override ci/prow/images |
@raukadah: Overrode contexts on behalf of raukadah: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
recheck-gate |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
2444537
into
openstack-k8s-operators:main
…omation Ensure we have one scenario per automation file This is in addition to a coming PR, #383. This change here is allowing to ensure we follow those practices: only one scenario per file filename matches "scenario_name.yaml" pattern
It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file openstack-k8s-operators#373 - NFV-HCI minor fixes Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. openstack-k8s-operators#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file.
So we are no longer needing default.yaml file.
Depends-On: openstack-k8s-operators/ci-framework#2292