Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport default.yaml split patches #394

Conversation

@fultonj
Copy link
Contributor

fultonj commented Sep 10, 2024

This looks fine to me. @cjeanner @eduolivares @eshulman2 please let me know when you think it's safe to merge.

@cjeanner
Copy link
Contributor

Once we get proper testing results, we should be able to merge. I've updated the Depends-On on the ci-framework PR that backports the needed change as well.

- name: Deploy Ceph
type: playbook
source: "../../playbooks/ceph.yml"
inventory: "${HOME}/ci-framework-data/artifacts/zuul_inventory.yml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It backports following patches:
openstack-k8s-operators#375 -  Move automation default vars into seperate scenario files
openstack-k8s-operators#383 - Drop default.yaml file
openstack-k8s-operators#379 - Ensure we have one scenario per automation file
openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file
openstack-k8s-operators#373 - NFV-HCI minor fixes

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
@eshulman2
Copy link
Contributor

lgtm

@eduolivares
Copy link
Contributor

lgtm
please merge together with openstack-k8s-operators/ci-framework#2333

Copy link
Contributor

@cjeanner cjeanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I took care of the ci-framework - will force-merge if prow's too slow there.

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ab2e02a into openstack-k8s-operators:18.0.0-proposed Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants