-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.11 support #601
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
83a74bf
Add Python 3.11 support
freyes 55c3f3f
Unpin pip and virtualenv
freyes ac2594f
Bump up tenacity to a version compatible with py311
freyes 4b0d23e
Migrate from nosetest to pytest
freyes a9d6812
Bump up flake8
freyes 2483be5
Add pytest.mark.asyncio
freyes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ | |
'juju<3.0', | ||
'juju-wait', | ||
'PyYAML', | ||
'tenacity', | ||
'tenacity>8.2.0', | ||
'python-libmaas', | ||
] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,20 @@ | ||
aiounittest | ||
flake8>=2.2.4 | ||
flake8>=5 # Python 3.8 compatibility in pyflakes 2.1.0+ | ||
flake8-docstrings | ||
flake8-per-file-ignores | ||
pydocstyle<4.0.0 | ||
coverage | ||
mock>=1.2 | ||
# For some reason the PyPi distributed wheel of nose differ from the one on | ||
# GitHub, and it does not work with Python 3.10. | ||
nose>=1.3.7;python_version<'3.10' | ||
git+https://github.com/nose-devs/nose.git@release_1.3.7#egg=nose;python_version=='3.10' | ||
pytest | ||
pytest-cov | ||
pytest-asyncio | ||
|
||
# TODO: these requirements should be mocked out in unit_tests/__init__.py | ||
async_generator | ||
jinja2 | ||
keystoneauth1 | ||
oslo.config | ||
python-novaclient | ||
tenacity | ||
tenacity>8.2.0 | ||
# pinned until 3.0 regressions are handled: https://github.com/openstack-charmers/zaza/issues/545 | ||
juju<3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pin seems a bit strange; is it to error out against something else pinning a lower version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's strange, something is inducing the resolver to pick tenacity-5.5, I don't know why, although this doesn't lead into any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest it is then!