Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 support #601

Merged
merged 6 commits into from
May 31, 2023
Merged

Conversation

freyes
Copy link
Member

@freyes freyes commented May 23, 2023

Summary of changes:

  • Bump up lower constraint on tenacity
  • Add python 3.11 to the testing matrix
  • Unpin pip and virtualenv
  • Bump up tenacity to a version compatible with py311
  • Migrate from nosetest to pytest
  • Bump up flake8

Summary of changes:

- Bump up lower constraint on tenacity
- Add python 3.11 to the testing matrix
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (6d79cf1) 89.25% compared to head (2483be5) 89.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   89.25%   89.17%   -0.09%     
==========================================
  Files          44       44              
  Lines        4655     4655              
==========================================
- Hits         4155     4151       -4     
- Misses        500      504       +4     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

nosetest has been deprecated long time ago, adopting a more established
unit test runner give us less problems as we move forward.
Fixes `AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'`
Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pytest now a requirement for py3.11?

@@ -28,7 +28,7 @@ python-neutronclient
python-novaclient
python-octaviaclient
python-swiftclient
tenacity
tenacity>8.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin seems a bit strange; is it to error out against something else pinning a lower version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's strange, something is inducing the resolver to pick tenacity-5.5, I don't know why, although this doesn't lead into any errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pytest now a requirement for py3.11?

not a 'requirement', although nose is no longer maintained, see nose-devs/nose#1118 (comment)

pytest it is then!

@freyes
Copy link
Member Author

freyes commented May 30, 2023

Is pytest now a requirement for py3.11?

not a 'requirement', although nose is no longer maintained, see nose-devs/nose#1118 (comment)

@ajkavanagh ajkavanagh merged commit b2f2b46 into openstack-charmers:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants