-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.11 support #601
Conversation
Summary of changes: - Bump up lower constraint on tenacity - Add python 3.11 to the testing matrix
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 89.25% 89.17% -0.09%
==========================================
Files 44 44
Lines 4655 4655
==========================================
- Hits 4155 4151 -4
- Misses 500 504 +4 ☔ View full report in Codecov by Sentry. |
nosetest has been deprecated long time ago, adopting a more established unit test runner give us less problems as we move forward.
Fixes `AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pytest now a requirement for py3.11?
@@ -28,7 +28,7 @@ python-neutronclient | |||
python-novaclient | |||
python-octaviaclient | |||
python-swiftclient | |||
tenacity | |||
tenacity>8.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pin seems a bit strange; is it to error out against something else pinning a lower version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's strange, something is inducing the resolver to pick tenacity-5.5, I don't know why, although this doesn't lead into any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pytest now a requirement for py3.11?
not a 'requirement', although nose is no longer maintained, see nose-devs/nose#1118 (comment)
pytest it is then!
not a 'requirement', although nose is no longer maintained, see nose-devs/nose#1118 (comment) |
Summary of changes: