-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map search bug fixes #3516
base: main
Are you sure you want to change the base?
Map search bug fixes #3516
Changes from 9 commits
c54d8ba
37a5ec8
0016007
6d8477a
552be3f
6b034e8
cb48a2d
3db24ca
7aac63f
7d561d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -237,9 +237,7 @@ | |
when { | ||
!searchQuery.isBlank() -> { | ||
IconButton( | ||
onClick = { | ||
onSearchTextChanged(SearchQuery.emptyText, performSearchOnValueChanged) | ||
}, | ||
onClick = { onSearchTextChanged(SearchQuery.emptyText, true) }, | ||
Check warning on line 240 in android/quest/src/main/java/org/smartregister/fhircore/quest/ui/main/components/TopScreenSection.kt Codecov / codecov/patchandroid/quest/src/main/java/org/smartregister/fhircore/quest/ui/main/components/TopScreenSection.kt#L240
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might it be better to fix it by passing the value true from the line here? Or even consider removing it entirely since the value There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ndegwamartin We want to automatically disable search on text change for the map but enable it for the registers. This disables it for the map. We however want to refresh the map view every time we clear data for both the register and map views hence the |
||
modifier = modifier.testTag(TRAILING_ICON_BUTTON_TEST_TAG), | ||
) { | ||
Icon( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add an edge case unit test for when we only have one item in the searchResults (if there's none already)