Map search bug fixes #3516
Map search bug fixes #3516
Conversation
- Updating the behaviour after clearing search bar on the maps
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
=========================================
- Coverage 27.2% 27.2% -0.1%
Complexity 756 756
=========================================
Files 278 278
Lines 14219 14220 +1
Branches 2581 2582 +1
=========================================
Hits 3880 3880
- Misses 9801 9802 +1
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@dubdabasoduba do we need a unit test for this? |
| onClick = { | ||
| onSearchTextChanged(SearchQuery.emptyText, performSearchOnValueChanged) | ||
| }, | ||
| onClick = { onSearchTextChanged(SearchQuery.emptyText, true) }, |
There was a problem hiding this comment.
Might it be better to fix it by passing the value true from the line here?
Or even consider removing it entirely since the value true is the default.
There was a problem hiding this comment.
@ndegwamartin We want to automatically disable search on text change for the map but enable it for the registers. This disables it for the map.
We however want to refresh the map view every time we clear data for both the register and map views hence the true. If we use performSearchOnValueChanged this is updated to false on the link you shared earlier.
| ) | ||
| val maxSublistIndex = min(toIndex, searchResults.size) | ||
|
|
||
| if (fromIndex < maxSublistIndex) { |
There was a problem hiding this comment.
We can add an edge case unit test for when we only have one item in the searchResults (if there's none already)
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3517
Fixes #3518
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile